Skip to content

Compare forbidCustomFunctions with spaze/phpstan-disallowed-calls#292

Open
janedbal wants to merge 2 commits intomasterfrom
compare-spaze
Open

Compare forbidCustomFunctions with spaze/phpstan-disallowed-calls#292
janedbal wants to merge 2 commits intomasterfrom
compare-spaze

Conversation

@janedbal
Copy link
Copy Markdown
Member

@janedbal janedbal commented Dec 3, 2024

This MR uses tests of our forbidCustomFunctions against logic in spaze/phpstan-disallowed-calls and changes the test files to display the diff of the behaviour.

Assuming our tests are correct then disallowed-calls reports:

  • false negative for any red diff (error removed)
  • false positive for any green diff (error added)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant