Open
Conversation
shining-man
reviewed
Jan 6, 2025
Owner
There was a problem hiding this comment.
Why did you set all the 'min' values to 0? That doesn't actually make sense for any cell chemistry.
The purpose is to limit the whole thing to a realistic range.
Owner
There was a problem hiding this comment.
In the future, please simply exclude this file from the PR. It is unnecessary and makes it less clear.
Owner
There was a problem hiding this comment.
In the future, please simply exclude this file from the PR. It is unnecessary and makes it less clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.