fix(ci): publish-packages workflow options and include hdwallet#12372
Conversation
- Move --workspace-concurrency and --filter to recursive position (before the `publish` subcommand); they aren't accepted as publish-command flags and were causing the first run to fail with "Unknown option: 'workspace-concurrency'". - Drop the !@shapeshiftoss/hdwallet-* exclusion in both publish and tag steps. hdwallet packages now live in this monorepo with no separate publish process, so consumers of chain-adapters/swapper currently pull pre-migration 1.62.41 from npm while local dist/ is built against the newer hdwallet sources. Folding them in lets the workflow publish them on the next version bump. - Correct the --workspace-concurrency=1 comment: workspace:^ rewriting is always against the local package.json regardless of order; the real reason for sequential publishing is registry consistency between dependency and dependent during the publish window. - Tag bootstrap for the 22 non-private hdwallet-*-v1.62.41 tags was pushed separately so the tagger doesn't tag develop HEAD on first run.
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Two-part fix to the
publish-packagesworkflow added in #12371.1. pnpm option position
The first run of the workflow failed with:
--workspace-concurrencyand--filterare recursive options, notpublishflags. They have to sit between-rand thepublishsubcommand; everything afterpublishis parsed as a publish-command flag. Reordered accordingly:2. Include
hdwallet-*in this workflowThe original workflow excluded
@shapeshiftoss/hdwallet-*on the basis that they were "versioned by a separate process". That was true when hdwallet lived in its own repo, but #11811 absorbed it into this monorepo in February — there is no separate publish process anymore.Concrete consequence today:
hdwallet-core@1.62.41was last published to npm on 2026-01-17, from the old repo.packages/hdwallet-*(phantom EIP-1474 fix, bebop solana signing, bitcoin wcv2 support, axios bump, etc.) — none are on npm.tsc --buildcompileschain-adapters/swapperdist/against the newer hdwallet sources, so consumers installingchain-adapters@11.3.9get JS/types that assume APIs paired withhdwallet-core@^1.62.41resolving to the old January code on npm. Silent breakage waiting to happen.This PR drops the
!@shapeshiftoss/hdwallet-*filter from both the publish step and the tagger. Private packages (hdwallet-integration,hdwallet-sandbox) are still skipped automatically.3. Corrected misleading comment
The
--workspace-concurrency=1comment claimed it was aboutworkspace:^resolution. It isn't —pnpm publishalways rewritesworkspace:^from the localpackage.jsonregardless of order. The real reason for sequential publishing is registry consistency: dependency reaches npm before dependent is published, so users installing during the publish window don't hit a missing dep. Comment updated to match reality.Issue (if applicable)
closes #
Risk
CI-only change. No runtime/UI impact in this repo. Downstream consumers of
@shapeshiftoss/*npm packages will start receiving correcthdwallet-*versions once those packages are bumped in a follow-up PR (current1.62.41is already on npm, so this PR alone is a no-op for hdwallet).Testing
Engineering
Required follow-ups before this workflow can actually publish hdwallet packages:
hdwallet-*packages on npmjs.com (org=shapeshift,repo=web,workflow=publish-packages.yml). Without these, the first hdwallet publish will fail withTrusted publisher configuration not found.hdwallet-*-v1.62.41annotated tags pushed tooriginat the migration commit4b625a5278. Verified viagit ls-remote --tags origin 'refs/tags/hdwallet-*-v1.62.41' | wc -l→ 22. Prevents the tagger from incorrectly taggingdevelopHEAD on first run.hdwallet-*versions in lockstep (e.g.,1.62.41→1.63.0across all 22).Workflow correctness can be sanity-checked locally:
Operations
CI-only workflow change. End-user impact depends on the follow-up version-bump PR, not this one.
Screenshots (if applicable)
n/a
🤖 Generated with Claude Code