Make Http API methods generic over their return type - #3584
Draft
mkrasnitski wants to merge 1 commit into
Draft
Conversation
Removes dependency on most model types by having the concrete type for deserialization decided by the caller rather than by `Http` directly.
github-actions
Bot
added
model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first of two PRs for preparing serenity to be split into multiple crates. Replaces the return type for http API methods with a generic
T: DeserializeOwned.This removes the
httpmodule's dependency on most model types by having the caller decide the concrete type for deserialization. This makes these methods less useful by themselves unless you know what exactly you're deserializing into, however this does mean that if Discord adds a new field to a response, users can define their own type for deserialization rather than waiting for serenity to add support or modifying the library themselves.