Run E2E test also for no-intensity mode - #193
Merged
Merged
Conversation
Contributor
✅ Passed noetic 3.20Log summarySummaryurg_stampedros-noetic-urg-stamped-0.4.1_git20251122023737-r0.apk |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #193 +/- ##
==========================================
+ Coverage 85.02% 85.68% +0.65%
==========================================
Files 37 37
Lines 2157 2158 +1
==========================================
+ Hits 1834 1849 +15
+ Misses 323 309 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR extends the E2E test to run in both intensity publishing modes (enabled and disabled), ensuring comprehensive test coverage for different configurations.
Key Changes:
- Parameterized the E2E test launch file to support both intensity publishing modes
- Split the single E2E test into two separate test runs with different intensity settings
- Updated build configuration to run both test variants
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/tests/e2e.test | Added publish_intensity argument and parameterized test name and GCOV prefix to support both modes |
| test/CMakeLists.txt | Separated test executable definition from test execution, added two add_rostest calls for each intensity mode |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.