build(deps): bump flask from 3.0.0 to 3.1.3 in /flask-otlp#1293
Open
dependabot[bot] wants to merge 1 commit intomasterfrom
Open
build(deps): bump flask from 3.0.0 to 3.1.3 in /flask-otlp#1293dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot[bot] wants to merge 1 commit intomasterfrom
Conversation
Bumps [flask](https://github.com/pallets/flask) from 3.0.0 to 3.1.3. - [Release notes](https://github.com/pallets/flask/releases) - [Changelog](https://github.com/pallets/flask/blob/main/CHANGES.rst) - [Commits](pallets/flask@3.0.0...3.1.3) --- updated-dependencies: - dependency-name: flask dependency-version: 3.1.3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
| @@ -1,6 +1,6 @@ | |||
| requests==2.27.1 | |||
| blinker==1.6.2 | |||
Contributor
There was a problem hiding this comment.
Bug: The upgrade to Flask==3.1.3 requires blinker>=1.9, but the requirements file still pins blinker==1.6.2, which will cause runtime failures on every request.
Severity: CRITICAL
Suggested Fix
Update the blinker dependency in flask-otlp/requirements.txt. Change blinker==1.6.2 to a version compatible with Flask 3.1.3, such as blinker>=1.9.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: flask-otlp/requirements.txt#L2
Potential issue: The pull request upgrades `Flask` to version `3.1.3` but leaves the
`blinker` dependency pinned at `1.6.2`. Flask `3.1.0` and newer introduced a requirement
for `blinker >= 1.9`. The application uses Flask's signal system via the
`@app.before_request` decorator. Due to this version incompatibility, the application
will fail at runtime on every incoming request when the signal system attempts to call
`blinker` APIs that do not exist in version `1.6.2`, leading to a crash on every
request.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps flask from 3.0.0 to 3.1.3.
Release notes
Sourced from flask's releases.
... (truncated)
Changelog
Sourced from flask's changelog.
... (truncated)
Commits
22d9247release version 3.1.3089cb86Merge commit from forkc17f379request context tracks session access27be933start version 3.1.34e652d3Abort if the instance folder cannot be created (#5903)3d03098Abort if the instance folder cannot be created407eb76document using gevent for async (#5900)ac5664ddocument using gevent for async4f79d5bIncrease required flit_core version to 3.11 (#5865)fe3b215Increase required flit_core version to 3.11Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.