Support protobuf (back again)#30
Open
ejalaa12 wants to merge 5 commits intosensmore:masterfrom
Open
Conversation
…ect.isabstract Co-authored-by: ejalaa12 <12619034+ejalaa12@users.noreply.github.com>
Co-authored-by: ejalaa12 <12619034+ejalaa12@users.noreply.github.com>
…features Add protobuf support, rebased onto sensmore/kappe master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
As a follow up to my previous PR (#18), I've rebased my work to support protobuf messages onto your recent refacto.
The main addition is the
ProtobufConverterPluginthat allows user to create plugins for protobuf messages.I've also added unit test and made sure my changes won't break your current features.
Hopefully, you think this is a good addition :)
Good work otherwise.