Conversation
Add sems_tests build and execution to all 7 Dockerfiles so that the Docker build fails early if any test regresses. RHEL builds run tests inline before make rpmtar; Debian builds run a separate cmake+make step before dpkg-buildpackage.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds unit test execution to all Docker builds to ensure tests pass before package creation. The implementation ensures that Docker builds fail early if any test regresses, improving the reliability of the build pipeline.
Changes:
- Added
make sems_tests && ./core/sems_teststo all 7 Dockerfiles (RHEL 7/8/9/10 and Debian 11/12/13) - RHEL builds run tests inline in the same RUN command before
make rpmtar - Debian builds run tests in a separate RUN command before
dpkg-buildpackage
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Dockerfile-rhel9 | Added test build and execution before rpmtar creation using cmake3 |
| Dockerfile-rhel8 | Added test build and execution before rpmtar creation using cmake3 |
| Dockerfile-rhel7 | Added test build and execution before rpmtar creation using cmake3 |
| Dockerfile-rhel10 | Added test build and execution before rpmtar creation using cmake (not cmake3) |
| Dockerfile-debian13 | Added separate test build and execution step before debian package build |
| Dockerfile-debian12 | Added separate test build and execution step before debian package build |
| Dockerfile-debian11 | Added separate test build and execution step before debian package build |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add sems_tests build and execution to all 7 Dockerfiles so that the Docker build fails early if any test regresses. RHEL builds run tests inline before make rpmtar; Debian builds run a separate cmake+make step before dpkg-buildpackage.