Fix callback crash when playing back entered digits (issue #180)#277
Merged
Fix callback crash when playing back entered digits (issue #180)#277
Conversation
The callback application crashed with a kernel trap when users entered digits followed by * or #. The bug was caused by undefined behavior: creating an empty string and writing to index 0. Fixed by properly converting character digits to strings using int2str(), which matches how prompts are registered. Also added debug logging to help troubleshoot digit playback. This fixes the issue where SEMS would restart after playing back the entered number.
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical crash in the callback application that occurred when users entered digits followed by * or #. The crash was caused by undefined behavior where an empty string was created and a character was written to index 0 without proper allocation.
Changes:
- Replaced undefined string manipulation with proper int2str() conversion to match prompt registration
- Added debug logging to track digit playback and aid troubleshooting
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The callback application crashed with a kernel trap when users entered digits followed by * or #. The bug was caused by undefined behavior: creating an empty string and writing to index 0.
Fixed by properly converting character digits to strings using int2str(), which matches how prompts are registered. Also added debug logging to help troubleshoot digit playback.
This fixes the issue where SEMS would restart after playing back the entered number.