Improvements to the Kotlin parser

[punchagan]

Checklist

• Any new parsing code was already published, integrated, and merged into Semgrep. DO NOT MERGE THIS PR BEFORE THE SEMGREP INTEGRATION WORK WAS COMPLETED.
• Change has no security implications (otherwise, ping the security team)

[yosefAlsuhaibani]

@punchagan feel free to ping me when this is ready to be reviewed!

[punchagan]

@yosefAlsuhaibani this PR is now ready for review. Once this PR is merged, I'm assuming you will be able to run the release kotlin command to update the semgrep/semgrep-kotlin repo.

[yosefAlsuhaibani]

Seems fine: I am slightly worried abt the added complexity of the scanner, but seems necessary to accommodate having a simple grammar.

[punchagan]

I am slightly worried abt the added complexity of the scanner, but seems necessary to accommodate having a simple grammar.

Yep. All the changes are from upstream, though. Hopefully any issues with the added complexity will get addressed upstream.

Let me know if you need me to do anything additionally on this, PR! Thanks for reviewing it.

[yosefAlsuhaibani]

@punchagan I just published the changes to semgrep/semgrep-kotlin; It should be available on this commit semgrep/semgrep-kotlin@1bddb22. Let's get that PR pointing to this commit!

[yosefAlsuhaibani]

I am slightly worried abt the added complexity of the scanner, but seems necessary to accommodate having a simple grammar.

Yep. All the changes are from upstream, though. Hopefully any issues with the added complexity will get addressed upstream.

Let me know if you need me to do anything additionally on this, PR! Thanks for reviewing it.

Of course, thank you for doing this work!