STRATCONN-5986 - [Facebook Pixel] - minor updates before Public beta#3615
Open
joe-ayoub-segment wants to merge 5 commits intomainfrom
Open
STRATCONN-5986 - [Facebook Pixel] - minor updates before Public beta#3615joe-ayoub-segment wants to merge 5 commits intomainfrom
joe-ayoub-segment wants to merge 5 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (31.86%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3615 +/- ##
===========================================
- Coverage 80.34% 31.86% -48.49%
===========================================
Files 1283 15 -1268
Lines 23583 747 -22836
Branches 4728 125 -4603
===========================================
- Hits 18947 238 -18709
+ Misses 3755 509 -3246
+ Partials 881 0 -881 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor tweaks after meeting with facebook.
Testing
Unit tests added. New integration.
Security Review
Please ensure sensitive data is properly protected in your integration.
type: 'password'New Destination Checklist
verioning-info.tsfile. example