Skip to content

/STRATCONN-6542 - [Attribution] - New Destination #3588

Open
joe-ayoub-segment wants to merge 6 commits intomainfrom
attribution
Open

/STRATCONN-6542 - [Attribution] - New Destination #3588
joe-ayoub-segment wants to merge 6 commits intomainfrom
attribution

Conversation

@joe-ayoub-segment
Copy link
Contributor

@joe-ayoub-segment joe-ayoub-segment commented Feb 10, 2026

New Attribution destination.

Testing

Unit tests added.
Needs testing by partner.

Security Review

Please ensure sensitive data is properly protected in your integration.

  • Reviewed all field definitions for sensitive data (API keys, tokens, passwords, client secrets) and confirmed they use type: 'password'

New Destination Checklist

  • Extracted all action API versions to verioning-info.ts file. example

@github-actions
Copy link
Contributor

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

  • Destination: Attribution, Settings:projectID
  • Destination: Attribution, Action:send, Fields:messageId,timestamp,type,event,userId,groupId

Add these new fields as optional instead and assume default values in perform or performBatch block.

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.38%. Comparing base (2481b96) to head (7b61bbd).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3588      +/-   ##
==========================================
+ Coverage   80.32%   80.38%   +0.05%     
==========================================
  Files        1283     1288       +5     
  Lines       23567    23633      +66     
  Branches     4726     4749      +23     
==========================================
+ Hits        18930    18997      +67     
+ Misses       3757     3755       -2     
- Partials      880      881       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@troex
Copy link

troex commented Feb 14, 2026

@joe-ayoub-segment please review #3595 - it contains authentication fix and we have added endpoint to test authentication.

On test runs looks good from our side - data is coming to Attribution in expected format

* [Attribution] fix auth use username as projectID

* add /check_auth and fix auth test
@joe-ayoub-segment
Copy link
Contributor Author

joe-ayoub-segment commented Feb 14, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments