/STRATCONN-6542 - [Attribution] - New Destination #3588
/STRATCONN-6542 - [Attribution] - New Destination #3588joe-ayoub-segment wants to merge 6 commits intomainfrom
Conversation
New required fields detectedWarning Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production. The following required fields were added in this PR:
Add these new fields as optional instead and assume default values in |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3588 +/- ##
==========================================
+ Coverage 80.32% 80.38% +0.05%
==========================================
Files 1283 1288 +5
Lines 23567 23633 +66
Branches 4726 4749 +23
==========================================
+ Hits 18930 18997 +67
+ Misses 3757 3755 -2
- Partials 880 881 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@joe-ayoub-segment please review #3595 - it contains authentication fix and we have added endpoint to test authentication. On test runs looks good from our side - data is coming to Attribution in expected format |
* [Attribution] fix auth use username as projectID * add /check_auth and fix auth test
New Attribution destination.
Testing
Unit tests added.
Needs testing by partner.
Security Review
Please ensure sensitive data is properly protected in your integration.
type: 'password'New Destination Checklist
verioning-info.tsfile. example