Conversation
Gesundheitsminister
commented
Nov 30, 2017
Gesundheitsminister
commented
- wrong mysqli links
- sql error on page copy
- session fix
Bringing fork up to date
* fixed sql error in fnc.con -> con_create_site_meta_from_idcatside
thinkh
left a comment
thinkh
left a comment
There was a problem hiding this comment.
Thanks for your bugfixes. I have some comments and questions before merging this PR.
| // | ||
| function get_file($file, $idclient = '', $iddirectory = '', $type = 1) { | ||
| if (empty($file)) return ''; // missing fileid | ||
| if (empty($file)) return array(); // missing fileid |
There was a problem hiding this comment.
Why do you use array() instead of [] in this file (2 times)?
There was a problem hiding this comment.
I tried to be compatible to php < 5.4. I dont know if this still makes sense.
| $sql = "INSERT INTO ".$cms_db['side']." (idclient) VALUES ('$idclient')"; | ||
| $db->query($sql); | ||
| $idside_to = mysqli_insert_id($this->db->Link_ID); | ||
| $idside_to = mysqli_insert_id($GLOBALS['db']->Link_ID); |
There was a problem hiding this comment.
$this->db is not set in this function. $GLOBALS['db'] is reliable.
| $sql .= '(' . $idcss . ', ' . $idcssfile . ')'; | ||
| $db->query($sql); | ||
| return mysqli_insert_id($this->db->Link_ID); | ||
| return mysqli_insert_id($GLOBALS['db']->Link_ID); |
There was a problem hiding this comment.
Same here: Why not using $db->Link_ID?
There was a problem hiding this comment.
Same problem. $this->db is not accessible everywhere.
backend/inc/inc.mod_config.php
Outdated
| mip_forms_ob_start(); | ||
| eval(' ?>' . $default); | ||
| $default_arr = mip_forms_get_array(); | ||
| //$cms_mod = empty($cms_mod) ? : $cms_mod; |
There was a problem hiding this comment.
I have removed it. Comes with the next update.
| $spaces .= sprintf($mip_forms_tab['tab'], ' '); | ||
| } | ||
|
|
||
| $mip_forms_tab['left_width'] = empty($mip_forms_tab['left_width']) ? 0 : $mip_forms_tab['left_width']; |
There was a problem hiding this comment.
It is important that $mip_forms_tab['left_width'] is initialised with an integer. PHP7 will miscalculate otherwise.
for some configurations.
for some configurations.
…it produces more problems than it solved * CHANGE: Removed Session fallback in local.php. Prevents showing session ids in Search engines.
2 participants
