Deprecate LSL vector and quaternion functions#75
Open
tapple wants to merge 3 commits intosecondlife:mainfrom
Open
Deprecate LSL vector and quaternion functions#75tapple wants to merge 3 commits intosecondlife:mainfrom
tapple wants to merge 3 commits intosecondlife:mainfrom
Conversation
tapple
commented
Mar 13, 2026
generated/slua_default.d.luau
Outdated
| Rot2Up: (Rotation: quaternion) -> vector, | ||
| Rot2Fwd: @[deprecated {use='quaternion.tofwd', reason='Fastcall.'}](Rotation: quaternion) -> vector, | ||
| Rot2Left: @[deprecated {use='quaternion.toleft', reason='Fastcall.'}](Rotation: quaternion) -> vector, | ||
| Rot2Up: @[deprecated {use='quaternion.toup', reason='Fastcall.'}](Rotation: quaternion) -> vector, |
Contributor
Author
There was a problem hiding this comment.
Are these actually fastcalls? I tried to figure it out from the slua code, but couldn't
Contributor
There was a problem hiding this comment.
afaik the fastcalls are all listed https://github.com/secondlife/slua/blob/73681935c9d1326ca3aaacf3dd1538798a15a76d/Common/include/Luau/Bytecode.h#L542-L684
Contributor
Author
There was a problem hiding this comment.
looks like not. removing that reason: 6ddcc0c
tapple
commented
Mar 13, 2026
| VecNorm: (Vector: vector) -> vector, | ||
| VecDist: @[deprecated {use='vector.magnitude', reason="It's a fastcall."}](Location1: vector, Location2: vector) -> number, | ||
| VecMag: @[deprecated {use='vector.magnitude', reason="It's a fastcall."}](Vector: vector) -> number, | ||
| VecNorm: @[deprecated {use='vector.normalize', reason="It's a fastcall."}](Vector: vector) -> vector, |
Contributor
Author
There was a problem hiding this comment.
Are these actually fastcalls? I tried to figure it out from the slua code, but couldn't
Contributor
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't quite like the replacement as much, mostly because it's longer to type. This might be better once they are methods: https://feedback.secondlife.com/slua-alpha/p/vector-type-should-behave-like-an-object . Although then we'd lose fastcall (Edit: apparently quaternion isn't fastcall anyway)