Deprecate the LSL list functions without a direct replacement#73
Open
tapple wants to merge 5 commits intosecondlife:mainfrom
Open
Deprecate the LSL list functions without a direct replacement#73tapple wants to merge 5 commits intosecondlife:mainfrom
tapple wants to merge 5 commits intosecondlife:mainfrom
Conversation
tapple
commented
Mar 13, 2026
| Dialog: (AvatarID: uuid, Text: string, Buttons: {string}, Channel: number) -> (), | ||
| Die: () -> (), | ||
| DumpList2String: (Source: list, Separator: string) -> string, | ||
| DumpList2String: @[deprecated {reason="Use 'table.concat' or 'lljson.encode' instead."}](Source: list, Separator: string) -> string, |
Contributor
Author
There was a problem hiding this comment.
table.concat is only equivilant if the list does not contain vectors, quaternions, or uuid's
There was a problem hiding this comment.
neither booleans, table.concat()only works with stringand number.
with lljson.encode()we can't choose a separator.
I think that ll.DumpList2String() is still useful.
tapple
commented
Mar 13, 2026
| ParcelMediaCommandList: (CommandList: list) -> (), | ||
| ParcelMediaQuery: (QueryList: {number}) -> {any}, | ||
| ParseString2List: (Text: string, Separators: {string}, Spacers: {string}) -> {string}, | ||
| ParseStringKeepNulls: (Text: string, Separators: {string}, Spacers: {string}) -> {string}, |
Contributor
Author
There was a problem hiding this comment.
I replaced ll.ParseStringKeepNulls with string.split in my code, but it has so many more options I don't think it's an adequate deprecation
tapple
commented
Mar 13, 2026
| Base64ToString: (Text: string) -> string, | ||
| BreakAllLinks: () -> (), | ||
| BreakLink: (LinkNumber: number) -> (), | ||
| CSV2List: (Text: string) -> {string}, |
Contributor
Author
There was a problem hiding this comment.
ll.CSV2List does string trimming as well; not easy to replicate. And I didn't think 'll.List2CSV` should be deprecated if it's pair isn't
tapple
changed the title
generated/slua_default.d.luau
Outdated
| List2List: <T>(ListVariable: {T}, Start: number, End: number) -> {T}, | ||
| List2ListSlice: <T>(ListVariable: {T}, Start: number, End: number, Stride: number, slice_index: number) -> {T}, | ||
| List2ListStrided: <T>(ListVariable: {T}, Start: number, End: number, Stride: number) -> {T}, | ||
| List2List: @[deprecated {use='unpack', reason='Prefer structured tables over strided lists.'}]<T>(ListVariable: {T}, Start: number, End: number) -> {T}, |
There was a problem hiding this comment.
or use table.move(t, start, end, 1, {})
generated/slua_default.d.luau
Outdated
| DeleteCharacter: () -> (), | ||
| DeleteKeyValue: (Key: string) -> uuid, | ||
| DeleteSubList: <T>(Source: {T}, Start: number, End: number) -> {T}, | ||
| DeleteSubList: @[deprecated {use='table.delete', reason='Prefer structured tables over strided lists.'}]<T>(Source: {T}, Start: number, End: number) -> {T}, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't expect this to be merged as-is, or possibly at all. Mostly opening it to have a discussion