Skip to content

Conversation

@polybassa
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 10, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.84%. Comparing base (a5bc2bb) to head (08b6fa4).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
scapy/supersocket.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4897   +/-   ##
=======================================
  Coverage   80.84%   80.84%           
=======================================
  Files         369      369           
  Lines       90963    90968    +5     
=======================================
+ Hits        73539    73544    +5     
  Misses      17424    17424           
Files with missing lines Coverage Δ
scapy/supersocket.py 75.97% <87.50%> (+0.05%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances type annotations for the SuperSocket class to improve typing support when working with AnsweringMachine instances. The changes add proper generic typing using TypeVar and update method signatures to provide better type inference.

Changes:

  • Added generic typing support with TypeVar for AnsweringMachine integration
  • Enhanced the am() method with proper type annotations using Generic types
  • Improved __enter__ method return type using Self for better type inference

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@polybassa polybassa merged commit f303033 into secdev:master Jan 11, 2026
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants