Icon support for Elpy#94
Open
Valdaer wants to merge 3 commits intosebastiencs:masterfrom
Open
Conversation
…de candidate inicon functions)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added support for https://github.com/jorgenschaefer/elpy . Unfortunately it requires
annotationparameter in addition tocandidateto determine what icon to display and this change would probably break people custom icon functions added incompany-box-icons-functionsso I don't know If it can be merged.I'm kind a beginner in elisp(if it would be in Python/Scala/Java probably I could figure something out) so I don't know if it can be done differently without too much hacks/workarounds and without breaking existing custom configs.
I can imagine that eventually some other company backend would also require
annotationto determine displayed icon but if you think that it can't be merged I think it would be good to keep this PR/issue for reference for other elpy users that would like to use this branch.