Add support for FPU flag for PDs - #404
Merged
Merged
Conversation
|
There is a good reason why I made the FPU enabled by default. If you do disable it by default, you better give a big warning that people should compile the code with -mgeneral-regs-only, otherwise they'll get crashes. |
JDuchniewicz
force-pushed
the
jakub/fpu_flag
branch
2 times, most recently
from
December 11, 2025 03:03
efe6d3d to
95044b3
Compare
Contributor
Author
|
Yes. Now it's enabled by default. |
midnightveil
requested changes
Dec 11, 2025
midnightveil
approved these changes
Mar 11, 2026
Contributor
|
Main issue is rust-sel4 PR, otherwise this is pretty trivial. For now I can merge the FPU changes into our rust-sel4 branch for development, but we'll need to merge that PR before the release. |
JDuchniewicz
force-pushed
the
jakub/fpu_flag
branch
2 times, most recently
from
March 31, 2026 07:00
d14b30a to
dafce4d
Compare
Contributor
Author
|
seL4/rust-sel4#316 is merged, we can proceed with this one |
|
I believe Line 16 in c83d507 |
Contributor
Author
|
@Willmish @Ivan-Velickovic I think the new domain-related functionality has to also be implemented/adjusted, as my PR was merged after that and cannot really base on it in isolation. |
JDuchniewicz
force-pushed
the
jakub/fpu_flag
branch
2 times, most recently
from
April 7, 2026 01:22
26f88b6 to
c82f9bc
Compare
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
Signed-off-by: Ivan Velickovic <i.velickovic@unsw.edu.au>
Ivan-Velickovic
force-pushed
the
jakub/fpu_flag
branch
from
April 10, 2026 06:13
90a828a to
eef1c79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In conjunction with seL4/rust-sel4#316 allows for using the
fpuflag to specify that a PD can be using the FPU.