Skip to content

Model: DiagVI (new)#3575

Open
ori-kron-wis wants to merge 120 commits intoscverse:mainfrom
quadbio:feature/spatial
Open

Model: DiagVI (new)#3575
ori-kron-wis wants to merge 120 commits intoscverse:mainfrom
quadbio:feature/spatial

Conversation

@ori-kron-wis
Copy link
Collaborator

No description provided.

WinterHannah and others added 30 commits May 13, 2025 16:41
Update feature branch to match upstream/main
…test-linux

Chore/ci disable schedule test linux
…-in-glue

2 basic batch encoding like in glue
…nce-graph-merge

merge to fix divergent branches
Update test_linux_custom_dataloader.yml
# for custom dataloders
dataloaders = ["lamindb>=1.12.1", "cellxgene-census", "tiledbsoma", "tiledbsoma_ml", "torchdata"]
# for diagvi
diagvi = ["torch_geometric", "geomloss"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need geomloss? It doesn't seem to be actively maintained.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Can, at the moment we rely on geomloss to compute the unbalanced optimal transport loss component. However, we are working on another approach based on POT, which is more actively maintained.

@ori-kron-wis ori-kron-wis mentioned this pull request Oct 30, 2025
@ori-kron-wis ori-kron-wis marked this pull request as ready for review October 30, 2025 12:10
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 88.59060% with 85 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.18%. Comparing base (5326dfa) to head (012343e).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/scvi/external/diagvi/_utils.py 79.20% 26 Missing ⚠️
src/scvi/external/diagvi/_base_components.py 67.10% 25 Missing ⚠️
src/scvi/external/diagvi/_model.py 92.92% 22 Missing ⚠️
src/scvi/external/diagvi/_module.py 91.17% 12 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (5326dfa) and HEAD (012343e). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (5326dfa) HEAD (012343e)
33 3
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3575      +/-   ##
==========================================
- Coverage   84.70%   75.18%   -9.53%     
==========================================
  Files         225      232       +7     
  Lines       21637    22603     +966     
==========================================
- Hits        18327    16993    -1334     
- Misses       3310     5610    +2300     
Files with missing lines Coverage Δ
src/scvi/external/__init__.py 85.71% <100.00%> (+0.42%) ⬆️
src/scvi/external/diagvi/__init__.py 100.00% <100.00%> (ø)
src/scvi/external/diagvi/_task.py 100.00% <100.00%> (ø)
src/scvi/model/base/_base_model.py 76.24% <100.00%> (-4.82%) ⬇️
src/scvi/external/diagvi/_module.py 91.17% <91.17%> (ø)
src/scvi/external/diagvi/_model.py 92.92% <92.92%> (ø)
src/scvi/external/diagvi/_base_components.py 67.10% <67.10%> (ø)
src/scvi/external/diagvi/_utils.py 79.20% <79.20%> (ø)

... and 70 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ori-kron-wis ori-kron-wis added the on-merge: backport to 1.4.x on-merge: backport to 1.4.x label Jan 15, 2026
@ori-kron-wis
Copy link
Collaborator Author

Hey @WinterHannah , what is the status of the PR? Should we expect more commits to it?
We can release it without docs or a tutorial, but they are very important for users to engage with the model.

@WinterHannah
Copy link

Hi @ori-kron-wis, I’ll be making a few commits to add documentation and a tutorial. It should take about a week at most!

Added docstring to every function, removed unnecessary code and comments, restructured parts of the code, fixed semi-supervision and feature imputation, added tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

on-merge: backport to 1.4.x on-merge: backport to 1.4.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants