Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #137 +/- ##
==========================================
- Coverage 88.83% 88.81% -0.02%
==========================================
Files 14 14
Lines 770 769 -1
==========================================
- Hits 684 683 -1
Misses 86 86
|
|
Hi @kmike |
| assert dummy.status == 300 | ||
|
|
||
| dummy = DummyResponse("https://google.com", 400) | ||
| assert dummy.status == 400 |
There was a problem hiding this comment.
Hey! The original issue was that .replace doesn't work; could you please add a test for this, or maybe even change this test to check .replace?
Users shouldn't be creating DummyResponse instances themselves, but they might have code which calls response.replace.
|
Looks good overall, thanks @FilippoPetroli! |
Solves issue #99