fix(ip): Don't offer neighbour, only neighbor#1318
Merged
Conversation
yedayak
force-pushed
the
ip-neigh-single
branch
from
aff7daf to
ae43b87
Compare
akinomyoga
approved these changes
Jan 19, 2025
Collaborator
akinomyoga
left a comment
akinomyoga
left a comment
There was a problem hiding this comment.
There might be a possibility of determining it by the current locale, but I think just neighbor is fine as US English is common in computing and we don't want complication.
scop
approved these changes
Jan 21, 2025
yedayak
force-pushed
the
ip-neigh-single
branch
from
ae43b87 to
1ffaf78
Compare
The previous state led to `ip neigh<TAB>` leading to this: ``` $ ip neighbo neighbor neighbour ``` choosing one to complete removes the need to choose between options that do the same thing, aligning with the CONTRIBUTING.md guidelines. I chose `neighbor` because it's shorter, but it can be changed if someone wants to.
yedayak
force-pushed
the
ip-neigh-single
branch
from
1ffaf78 to
bb1097a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous state led to
ip neigh<TAB>leading to this:choosing one to complete removes the need to choose between options that do the same thing, aligning with the CONTRIBUTING.md guidelines.
I chose
neighborbecause it's shorter, but it can be changed if someone wants to.