Skip to content

Lookup relative error threshold #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jl-wynen merged 6 commits into from
Mar 17, 2026
Merged

Lookup relative error threshold #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6e4057a
Update dependencies
jl-wynen Mar 9, 2026
edb8ec9
Set lookup error thresholds
jl-wynen Mar 9, 2026
744d4d3
manually remove position coord
nvaytet Mar 16, 2026
2aa3282
move removal of position coord in monitor wavelength provider which w…
nvaytet Mar 17, 2026
156a1c1
revert all changes in file
nvaytet Mar 17, 2026
6924361
Apply automatic formatting
pre-commit-ci-lite[bot] Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions docs/user-guide/loki/loki-make-tof-lookup-table.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@
"wf[time_of_flight.PulseStride] = 1\n",
"wf[time_of_flight.LtotalRange] = sc.scalar(9.0, unit=\"m\"), sc.scalar(35.0, unit=\"m\")\n",
"wf[time_of_flight.DistanceResolution] = sc.scalar(0.1, unit=\"m\")\n",
"wf[time_of_flight.TimeResolution] = sc.scalar(250.0, unit='us')\n",
"wf[time_of_flight.LookupTableRelativeErrorThreshold] = 1.0"
"wf[time_of_flight.TimeResolution] = sc.scalar(250.0, unit='us')"
]
},
{
Expand Down Expand Up @@ -117,7 +116,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.12.7"
"version": "3.11.10"
}
},
"nbformat": 4,
Expand Down
2 changes: 1 addition & 1 deletion docs/user-guide/loki/loki-reduction-ess.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.12.7"
"version": "3.11.10"
}
},
"nbformat": 4,
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ requires-python = ">=3.11"
dependencies = [
"dask>=2022.1.0",
"graphviz>=0.20",
"essreduce>=26.01.0",
"essreduce>=26.3.1",
"numpy>=1.26.4",
"pandas>=2.1.2",
"plopp>=25.10.0",
Expand Down
2 changes: 1 addition & 1 deletion requirements/base.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# The following was generated by 'tox -e deps', DO NOT EDIT MANUALLY!
dask>=2022.1.0
graphviz>=0.20
essreduce>=26.01.0
essreduce>=26.3.1
numpy>=1.26.4
pandas>=2.1.2
plopp>=25.10.0
Expand Down
40 changes: 20 additions & 20 deletions requirements/base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SHA1:1189f4e0fca2ce44df155754d5138de237818e68
# SHA1:0260a75a29cca7526b260641dc9f8ceed51c38e9
#
# This file was generated by pip-compile-multi.
# To update, run:
Expand All @@ -21,25 +21,25 @@ cyclebane==24.10.0
# via sciline
cycler==0.12.1
# via matplotlib
dask==2026.1.1
dask==2026.1.2
# via -r base.in
decorator==5.2.1
# via ipython
dnspython==2.8.0
# via email-validator
email-validator==2.3.0
# via scippneutron
essreduce==26.1.1
essreduce==26.3.1
Copy link
Member

@nvaytet nvaytet Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be set as a lower bound in the pyproject.toml?

Copy link
Member Author

@jl-wynen jl-wynen Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

# via -r base.in
executing==2.2.1
# via stack-data
fonttools==4.61.1
fonttools==4.62.0
# via matplotlib
fsspec==2026.1.0
fsspec==2026.2.0
# via dask
graphviz==0.21
# via -r base.in
h5py==3.15.1
h5py==3.16.0
# via
# scippneutron
# scippnexus
Expand All @@ -49,7 +49,7 @@ importlib-metadata==8.7.1
# via dask
ipydatawidgets==4.3.5
# via pythreejs
ipython==9.9.0
ipython==9.10.0
# via ipywidgets
ipython-pygments-lexers==1.1.1
# via ipython
Expand All @@ -61,9 +61,9 @@ jedi==0.19.2
# via ipython
jupyterlab-widgets==3.0.16
# via ipywidgets
kiwisolver==1.4.9
kiwisolver==1.5.0
# via matplotlib
lazy-loader==0.4
lazy-loader==0.5
# via
# plopp
# scippneutron
Expand All @@ -75,11 +75,11 @@ matplotlib==3.10.8
# plopp
matplotlib-inline==0.2.1
# via ipython
mpltoolbox==25.10.0
mpltoolbox==26.2.0
# via scippneutron
networkx==3.6.1
# via cyclebane
numpy==2.4.1
numpy==2.4.3
# via
# -r base.in
# contourpy
Expand All @@ -96,17 +96,17 @@ packaging==26.0
# dask
# lazy-loader
# matplotlib
pandas==3.0.0
pandas==3.0.1
# via -r base.in
parso==0.8.5
parso==0.8.6
# via jedi
partd==1.4.2
# via dask
pexpect==4.9.0
# via ipython
pillow==12.1.0
pillow==12.1.1
# via matplotlib
plopp==25.11.0
plopp==26.3.0
# via
# -r base.in
# scippneutron
Expand Down Expand Up @@ -139,22 +139,22 @@ sciline==25.11.1
# via
# -r base.in
# essreduce
scipp==26.1.1
scipp==26.3.0
# via
# -r base.in
# essreduce
# scippneutron
# scippnexus
scippneutron==25.11.2
scippneutron==26.3.0
# via
# -r base.in
# essreduce
scippnexus==26.1.0
scippnexus==26.1.1
# via
# -r base.in
# essreduce
# scippneutron
scipy==1.17.0
scipy==1.17.1
# via
# scippneutron
# scippnexus
Expand Down Expand Up @@ -183,7 +183,7 @@ typing-extensions==4.15.0
# typing-inspection
typing-inspection==0.4.2
# via pydantic
wcwidth==0.3.0
wcwidth==0.6.0
# via prompt-toolkit
widgetsnbextension==4.0.15
# via ipywidgets
Expand Down
24 changes: 12 additions & 12 deletions requirements/basetest.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
#
asttokens==3.0.1
# via stack-data
certifi==2026.1.4
certifi==2026.2.25
# via requests
charset-normalizer==3.4.4
charset-normalizer==3.4.5
# via requests
comm==0.2.3
# via ipywidgets
Expand All @@ -21,15 +21,15 @@ decorator==5.2.1
# via ipython
executing==2.2.1
# via stack-data
fonttools==4.61.1
fonttools==4.62.0
# via matplotlib
idna==3.11
# via requests
iniconfig==2.3.0
# via pytest
ipympl==0.10.0
# via -r basetest.in
ipython==9.9.0
ipython==9.10.0
# via
# ipympl
# ipywidgets
Expand All @@ -41,13 +41,13 @@ jedi==0.19.2
# via ipython
jupyterlab-widgets==3.0.16
# via ipywidgets
kiwisolver==1.4.9
kiwisolver==1.5.0
# via matplotlib
matplotlib==3.10.8
# via ipympl
matplotlib-inline==0.2.1
# via ipython
numpy==2.4.1
numpy==2.4.3
# via
# contourpy
# ipympl
Expand All @@ -58,19 +58,19 @@ packaging==26.0
# matplotlib
# pooch
# pytest
parso==0.8.5
parso==0.8.6
# via jedi
pexpect==4.9.0
# via ipython
pillow==12.1.0
pillow==12.1.1
# via
# ipympl
# matplotlib
platformdirs==4.5.1
platformdirs==4.9.4
# via pooch
pluggy==1.6.0
# via pytest
pooch==1.8.2
pooch==1.9.0
# via -r basetest.in
prompt-toolkit==3.0.52
# via ipython
Expand All @@ -91,7 +91,7 @@ python-dateutil==2.9.0.post0
# via matplotlib
requests==2.32.5
# via pooch
scipy==1.17.0
scipy==1.17.1
# via -r basetest.in
six==1.17.0
# via python-dateutil
Expand All @@ -107,7 +107,7 @@ typing-extensions==4.15.0
# via ipython
urllib3==2.6.3
# via requests
wcwidth==0.3.0
wcwidth==0.6.0
# via prompt-toolkit
widgetsnbextension==4.0.15
# via ipywidgets
24 changes: 14 additions & 10 deletions requirements/ci.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,19 @@
#
# requirements upgrade
#
cachetools==6.2.4
cachetools==7.0.5
# via tox
certifi==2026.1.4
certifi==2026.2.25
# via requests
chardet==5.2.0
# via tox
charset-normalizer==3.4.4
charset-normalizer==3.4.5
# via requests
colorama==0.4.6
# via tox
distlib==0.4.0
# via virtualenv
filelock==3.20.3
filelock==3.25.1
# via
# python-discovery
# tox
# virtualenv
gitdb==4.0.12
Expand All @@ -32,21 +31,26 @@ packaging==26.0
# -r ci.in
# pyproject-api
# tox
platformdirs==4.5.1
platformdirs==4.9.4
# via
# python-discovery
# tox
# virtualenv
pluggy==1.6.0
# via tox
pyproject-api==1.10.0
# via tox
python-discovery==1.1.2
# via virtualenv
requests==2.32.5
# via -r ci.in
smmap==5.0.2
smmap==5.0.3
# via gitdb
tox==4.34.1
tomli-w==1.2.0
# via tox
tox==4.49.1
# via -r ci.in
urllib3==2.6.3
# via requests
virtualenv==20.36.1
virtualenv==21.2.0
# via tox
12 changes: 6 additions & 6 deletions requirements/dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ argon2-cffi-bindings==25.1.0
# via argon2-cffi
arrow==1.4.0
# via isoduration
async-lru==2.1.0
async-lru==2.2.0
# via jupyterlab
cffi==2.0.0
# via argon2-cffi-bindings
copier==9.11.2
copier==9.13.1
# via -r dev.in
dunamai==1.25.0
dunamai==1.26.0
# via copier
fqdn==1.5.1
# via jsonschema
Expand Down Expand Up @@ -65,7 +65,7 @@ jupyter-server==2.17.0
# notebook-shim
jupyter-server-terminals==0.5.4
# via jupyter-server
jupyterlab==4.5.2
jupyterlab==4.5.5
# via -r dev.in
jupyterlab-server==2.28.0
# via jupyterlab
Expand All @@ -77,7 +77,7 @@ overrides==7.7.0
# via jupyter-server
pip-compile-multi==3.2.2
# via -r dev.in
pip-tools==7.5.2
pip-tools==7.5.3
# via pip-compile-multi
plumbum==1.10.0
# via copier
Expand Down Expand Up @@ -115,7 +115,7 @@ webcolors==25.10.0
# via jsonschema
websocket-client==1.9.0
# via jupyter-server
wheel==0.46.2
wheel==0.46.3
# via pip-tools

# The following packages are considered to be unsafe in a requirements file:
Expand Down
Loading
Loading