Check army and navy validity#1799
Conversation
|
|
||
| for(auto map_army : state.world.in_army) { | ||
| if(!state.world.army_is_valid(map_army)) { | ||
| return; |
There was a problem hiding this comment.
If the army possibly being invalid is a problem, this won't actually fix anything, because it can still become invalid after this check. The game is running in parallel with this function
|
Recent changes introduce dynamic infamy calculation based on country/state size. |
|
It looks like you have added target_state to the available cbs, but haven't actually done anything with it. It probably shouldn't be added until we have something that needs it. (Yes, I know that you made fabrication target a specific state, but I do not think that this restriction currently adds anything to the game at the cost of making it harder for the AI to accidentally coordinate, as we discussed previously) |
|
Also, you should run your changes to how infamy work by the players first. It isn't a big code change, but it is a large change to how the game works. |
|
Probe of the community in Discord produced zero negative feedback. |
Unitupgrade
2 participants
No description provided.