Fix -Ymagic-offset-header for DoubleDefinition error#25706
Open
lihaoyi wants to merge 1 commit intoscala:mainfrom
Open
Fix -Ymagic-offset-header for DoubleDefinition error#25706lihaoyi wants to merge 1 commit intoscala:mainfrom
-Ymagic-offset-header for DoubleDefinition error#25706lihaoyi wants to merge 1 commit intoscala:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the reported error properly use remapped file paths and line numbers, where previously it did not. This was encountered trying to use
-Ymagic-offset-headerto properly refer to Mill's source.millscripts during error reporting rather than wrapped generated source filesHow much have you relied on LLM-based tools in this contribution?
Mostly vibe coded with claude
How was the solution tested?
Added a new unit test
Additional notes