Skip doc generation for nonbootstrapped projects#25705
Merged
tanishiking merged 1 commit intoscala:mainfrom Apr 4, 2026
Merged
Skip doc generation for nonbootstrapped projects#25705tanishiking merged 1 commit intoscala:mainfrom
tanishiking merged 1 commit intoscala:mainfrom
Conversation
fix scala#25704 Previously, running `sbt publishLocal` causes scaladoc generation for `scala-library-nonbootstrapped` and `scala3-library-nonbootstrapped`. These two projects don't explicitly set `Compile / packageDoc / publishArtifact := false`, and therefore sbt defaults to generate doc jars on `publishLocal`. However, IIUC, there's no point of generating scaladoc for nonbootstrapped projects because these artifacts are only published locally for bootstrapping (and local development), and the bootstrapped projects reference packageBin outputs and don't care about packageDoc. In fact, other nonbootstrapped projects like `scala3-compiler-nonbootstrapped` and `tasty-core-nonbootstrapped` already set `packageDoc / publishArtifact := false`. In my local environemnt, clean build with `publishLocal`, previously took 230s, and not it took around 90s.
tgodzik
approved these changes
Apr 3, 2026
Contributor
tgodzik
left a comment
tgodzik
left a comment
There was a problem hiding this comment.
Makes sense! I had claude on it at some point and the same was suggested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #25704
Previously, running
sbt publishLocalcauses scaladoc generation forscala-library-nonbootstrappedandscala3-library-nonbootstrapped.These two projects don't explicitly set
Compile / packageDoc / publishArtifact := false, and therefore sbt defaults to generate doc jars onpublishLocal.However, IIUC, there's no point of generating scaladoc for nonbootstrapped projects because these artifacts are only published locally for bootstrapping (and local development), and the bootstrapped projects reference packageBin outputs and don't care about packageDoc. In fact, other nonbootstrapped projects like
scala3-compiler-nonbootstrappedandtasty-core-nonbootstrappedalready setpackageDoc / publishArtifact := false.In my local environemnt, clean build with
publishLocal, previously took 230s, and not it took around 90s.How much have you relied on LLM-based tools in this contribution?
not used
How was the solution tested?
Run
sbt publishLocallocally. I'd like to confirm my assumption that disable doc publishing for nonbootstrapped project is safe.Additional notes