Merged
Conversation
This reverts commit d8c87a7.
e4dc487 to
2168115
Compare
Member
Author
|
Thanks for documenting these regressions Wojciech and sorry for the trouble! |
Contributor
|
If possible let's add the snippets the 3 PRs as future regression tests |
1cb547a to
da3c023
Compare
WojciechMazur
approved these changes
Apr 3, 2026
Member
Author
|
Regression test for #25690 doesn't pass with Looking at it now. |
Avoid producing a Typed node that -Xcheck-macros cannot verify for path-dependent types, while still reproducing the regression without the revert. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the wide scope of the regression introduced by #24431, I think it's best to revert for now, until I figure out how to fix it.
Closes #25690, closes #25692 and closes #25697.