Make tests for capability parents of Array class more robust#25695
Merged
odersky merged 3 commits intoscala:mainfrom Apr 2, 2026
Merged
Make tests for capability parents of Array class more robust#25695odersky merged 3 commits intoscala:mainfrom
odersky merged 3 commits intoscala:mainfrom
Conversation
It was quite leaky before, which was hidden by the fact that we added these parents manually to the array class in transformSym. But this works only if separation checking is specified by a setting, since transformSym does not have access to the current compilation unit. So we need to drop the special logic in transformSym and rely on the fixed derivedFromCapTrait tests instead. Fixes scala#25644
It only worked reliably if separation checking was turned by a setting. Language imports were not guaranteed to work. So it's better to turn off this logic and rely on the other changes that all do take care of arrays in both modes.
noti0na1
reviewed
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was quite leaky before, which was hidden by the fact that we added these
parents manually to the array class in transformSym. But this works only if
separation checking is specified by a setting, since transformSym does not have
access to the current compilation unit. So we need to drop the special
logic in transformSym and rely on the fixed derivedFromCapTrait tests
instead.
Fixes #25644