Optimize the standard library in bootstrapped compilation#25689
Optimize the standard library in bootstrapped compilation#25689SolalPirelli wants to merge 1 commit intoscala:mainfrom
Conversation
SolalPirelli
added
the
needs-minor-release
| } | ||
|
|
||
| val rSum = r.sum(mynum) | ||
| val rSum = r.sum(using mynum) |
There was a problem hiding this comment.
noticed this as a warning in compilation output, I must've missed it when porting the scalacheck stuff
| Compile / unmanagedResourceDirectories := Seq(baseDirectory.value / "resources"), | ||
| Compile / compile / scalacOptions ++= Seq( | ||
| /* TODO: enable for Scala 3.9: "-opt", "-opt-inline:**,!java.**", */ | ||
| "-opt", "-opt-inline:**,!java.**", |
There was a problem hiding this comment.
I think we might still need 3.9, @WojciechMazur or we just do 3.8.4-RC2 with the backported regression?
|
If we put this directly into the default config, we must also disable incremental compilation of the bootstrapped library. Inlining from |
|
We never enabled the optimizer in local development mode in the Scala 2 repo, only in CI for test and release builds. Inlining breaks incremental compilation indeed, and also increases compile times. On the other hand, in Scala 2 bootstrapping is handled outside the sbt build. I don't know how much anyone's workflow is affected by applying it to the bootstrapped build. |
4 participants
Fixes #25688
How much have you relied on LLM-based tools in this contribution?
not
How was the solution tested?
existing tests that were recently ported