Scoverage & CC interaction: exempt CC nested symbols from @experimental check#25687
Open
anatoliykmetyuk wants to merge 1 commit intoscala:mainfrom
Open
Scoverage & CC interaction: exempt CC nested symbols from @experimental check#25687anatoliykmetyuk wants to merge 1 commit intoscala:mainfrom
anatoliykmetyuk wants to merge 1 commit intoscala:mainfrom
Conversation
Coverage lifting creates synthetic ValDefs whose type trees expose class-level TypeRefs (e.g. `class containsImpl`) to CrossVersionChecks. These class symbols carry @experimental directly, bypassing the ccExperimental exemption that works for their owner (Contains object). Extend ccException to also check sym.owner, so members of CC-exempted definitions are automatically exempted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture checking introduces some
experimentalsymbols that are exempt from experimental checks with capture checking enabled. Currently, exemptions are only applied to the symbol itself, not its owner.Coverage instrumentation introduces synthetic
ValDefs which may expose capture checking symbols owned by experimental classes to experimental checks, bypassing the exemption.This PR hardens the exemption to apply check the owner of the symbol as well.
How much have you relied on LLM-based tools in this contribution?
Moderately.
How was the solution tested?