Enable sc:compile for scala.util Package#25651
Open
cheeseng wants to merge 1 commit intoscala:mainfrom
Open
Conversation
natsukagami
reviewed
Mar 31, 2026
Comment on lines
+65
to
+67
| * ```scala sc:compile | ||
| * import scala.util.Try | ||
| * |
Contributor
There was a problem hiding this comment.
I wonder if we can use reusable sc-name snippets and hidden snippets like we can do in Markdown scaladoc for these
Contributor
Author
There was a problem hiding this comment.
@natsukagami that's a good idea, I have made the change and squashed the commits into one.
…used sc-name and sc-hidden for context code, and adjusted the code snippets to get them to compile correctly.
cheeseng
force-pushed
the
feature-enable-stdlib-sc-compile
branch
from
3d45337 to
680a398
Compare
SethTisue
reviewed
Apr 3, 2026
| * for (...) { | ||
| * if (...) break | ||
| * for (i <- 1 to 10) { | ||
| * if (i == 5) break |
Member
There was a problem hiding this comment.
I suggest using Scala 3 style for...do and if...then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add sc:compile and sc:nocompile to code snippets under
scala.utilpackage, add necessary code to make them compile successfully.