Fix #25624: Scoverage and separation checking failures#25625
Open
anatoliykmetyuk wants to merge 2 commits intoscala:mainfrom
Open
Fix #25624: Scoverage and separation checking failures#25625anatoliykmetyuk wants to merge 2 commits intoscala:mainfrom
anatoliykmetyuk wants to merge 2 commits intoscala:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25624
Separation checking for captures relies on
unsafeAssumeSeparateto opt out of separation checking. To detect such code,SepCheckuses structural matching on the trees. Coverage phase may lift some trees, breaking the assumptions about the structure.This PR:
unsafeAssumeSeparateout of coverage instrumentation - we aren't really interested in coverage info on it anyway, only the body is interestingSepChecktime, opts-out synthetic trees created by coverage from separation checking - rationalle being we have already checked their rhs for separation on assignment timeHow much have you relied on LLM-based tools in this contribution?
Moderately.
How was the solution tested?
testCompilation --enable-coverage-phasesuitepossuiteAdditional notes
I am not familiar with the captures codebase, so can use help of someone familiar with it to review this PR.