[WIP] Run tests with valgrind - #104
Open
kornilova203 wants to merge 3 commits into
Open
Conversation
Member
|
We could run the checks in a separate build in the matrix, which only runs the tests that exercise |
kornilova203
force-pushed
the
valgrind-tests
branch
from
July 13, 2018 11:55
181760b to
ff8bab2
Compare
kornilova203
force-pushed
the
valgrind-tests
branch
from
July 13, 2018 11:58
ff8bab2 to
30d61e3
Compare
Member
Author
|
I updated scripts for travis such that it runs memory checks only in build with llvm 5.0. addCommandAlias(
"verifyWithoutMemoryChecks",
"; ^test:compile ; " +
"^testOnly -- -z \"should exist\" -z \"correct bindings\" ; " +
"^scripted ; " +
"docs/makeSite")So when new tests are added |
Member
|
How about using ScalaTest tags? https://alvinalexander.com/scala/scalatest-mark-tests-tags-to-include-exclude-sbt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #84
I am not satisfied with the implementation because memory checks are executed with regular tests and it take a lot of time.
I did not find a way to filter tests by substring (there is
testOnlybut does not allow to exclude tests)I am not sure whether I should move them to separate test class, it feels like they fit to
BindgenSpec.