Skip to content

[WIP] Run tests with valgrind - #104

Open
kornilova203 wants to merge 3 commits into
masterfrom
valgrind-tests
Open

[WIP] Run tests with valgrind#104
kornilova203 wants to merge 3 commits into
masterfrom
valgrind-tests

Conversation

@kornilova203

Copy link
Copy Markdown
Member

Closes #84
I am not satisfied with the implementation because memory checks are executed with regular tests and it take a lot of time.
I did not find a way to filter tests by substring (there is testOnly but does not allow to exclude tests)
I am not sure whether I should move them to separate test class, it feels like they fit to BindgenSpec.

@jonas

jonas commented Jul 6, 2018

Copy link
Copy Markdown
Member

We could run the checks in a separate build in the matrix, which only runs the tests that exercise scala-native-bindgen. When the bindings get added we can also use those to test with valgrind.

@kornilova203

Copy link
Copy Markdown
Member Author

I updated scripts for travis such that it runs memory checks only in build with llvm 5.0.
Not sure if I did it right because I added sbt command alias that includes all tests except memory tests:

addCommandAlias(
  "verifyWithoutMemoryChecks",
  "; ^test:compile ; " +
    "^testOnly -- -z \"should exist\" -z \"correct bindings\" ; " +
    "^scripted ; " +
    "docs/makeSite")

So when new tests are added verifyWithoutMemoryChecks should be updated.

@jonas

jonas commented Jul 13, 2018

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants