chore: update webviews to retain context when hidden#1800
Open
scottdover wants to merge 3 commits intomainfrom
Open
chore: update webviews to retain context when hidden#1800scottdover wants to merge 3 commits intomainfrom
scottdover wants to merge 3 commits intomainfrom
Conversation
added 2 commits
February 20, 2026 11:29
Signed-off-by: Scott Dover <Scott.Dover@sas.com>
Signed-off-by: Scott Dover <Scott.Dover@sas.com>
Signed-off-by: Scott Dover <Scott.Dover@sas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This changes how
DataViewermaintains context. In our first iteration,retainContextWhenHidden: truewas avoided because the documentation said:With that in mind, the implementation relied on re-fetching data each time a view was displayed. As
DataViewergrows increasingly complex, the amount of state required to persist/fetch data will be increase.Thus, this PR changes things such that we retain context when switching between tabs. The downside is that there is a higher memory footprint (it was hard to find data on this but a stack overflow post suggested an empty web view using
retainContextWhenHidden: trueconsumes 50mb of memory). However, there are numerous upsides:Testing: