Skip orphaned criteria in unsatisfied_names#204
Open
notatallshaw wants to merge 1 commit intosarugaku:mainfrom
Open
Skip orphaned criteria in unsatisfied_names#204notatallshaw wants to merge 1 commit intosarugaku:mainfrom
notatallshaw wants to merge 1 commit intosarugaku:mainfrom
Conversation
Collaborator
Author
|
@frostming I found this while investigating performance optimizations, it usually requires fairly complex backtracking scenarios to trigger in my testing (barely triggers in many of the backtracking scenarios I have for pip). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
_remove_information_from_criteriaempties a criterion's information list, skip it inunsatisfied_namesinstead of pinning it and its transitive deps for nothing.Found via pip on
kedro[test]==0.18.13(12 orphaned packages pinned then discarded by_build_result).