Correct PythonInputProvider._iter_matches to fix tests with packaging 26.0#201
Merged
notatallshaw merged 1 commit intosarugaku:mainfrom Feb 13, 2026
Merged
Conversation
notatallshaw
force-pushed
the
fix-tests-packaging-26.0
branch
from
ec5c4e1 to
5629c5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #200
PythonInputProvider._iter_matchesis implemented wrong, you need to iterate though all versions excluding incomparable versions, and then apply the combinedSpecifierSetin one go, this allowsSpecifierSetto apply the full PEP 440 logic to all available versions.This may be able to be simplified when packaging 26.1 comes out because there will be a key parameter to filter, allowing to filter candidates or requirements directly: pypa/packaging#1066