[i41] - Fix view specs to prioritize knapsack views over hyrax-webapp…#42
Merged
ShanaLMoore merged 2 commits intomainfrom Oct 23, 2025
Merged
[i41] - Fix view specs to prioritize knapsack views over hyrax-webapp…#42ShanaLMoore merged 2 commits intomainfrom
ShanaLMoore merged 2 commits intomainfrom
Conversation
… views Issue - #41 Add knapsack_view_helpers.rb to automatically prepend knapsack view paths for all view specs - Fix Fixtures::FixtureFileUpload error in rails_helper.rb by making it conditional - This allows view specs in the knapsack to correctly test knapsack view overlays"
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #41 by ensuring view specs in the knapsack correctly prioritize knapsack views over hyrax-webapp views. This is accomplished by automatically prepending knapsack view paths in the test environment and fixing a conditional dependency issue.
- Adds automatic view path prepending for all view specs
- Makes FixtureFileUpload inclusion conditional to prevent errors
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spec/support/knapsack_view_helpers.rb | Introduces shared context to prepend knapsack view paths for view specs |
| spec/rails_helper.rb | Makes FixtureFileUpload inclusion conditional on its availability |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… views
Issue
Add knapsack_view_helpers.rb to automatically prepend knapsack view paths for all view specs