🚧 Fix view path priority in test environment#40
Closed
ShanaLMoore wants to merge 2 commits intomainfrom
Closed
Conversation
- Add automatic view path configuration in rails_helper.rb - Ensure knapsack views are prioritized over hyrax-webapp views in tests - Add KnapsackViewPathHelper for manual view path control - Add test coverage for view path priority - Add documentation for the fix This fixes an issue where view specs would render hyrax-webapp views instead of knapsack overlay views in the test environment. Resolves the issue reported where view specs were not using the local knapsack overlay views.
- Ensures knapsack views are prioritized over hyrax-webapp views in tests - Uses simplified approach targeting view.view_paths directly - Fixes issue where view specs rendered hyrax-webapp views instead of knapsack overlays - Automatic configuration - no manual intervention needed per test - Maintains compatibility with existing theme view path handling Resolves view path priority issues in test environment while preserving production behavior and theme system functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where view specs would render hyrax-webapp views instead of knapsack overlay views in the test environment.