Develop Main #338
Merged
Develop Main #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#335) * added: Teiler Dashboard Version * added: MTBA Version * added: beam proxy tag version
torbrenner
approved these changes
Aug 20, 2025
Member
|
Currently only the latest tag exist and by re-using the defined environment variable, sites that have set said variable would break. Let us please first discuss the naming and tagging strategy with the DNPM:DIP developers before making it flexible (again). For now, hard coded tags are my preference.
-------- Original Message --------On 20/08/2025 08:18, Torben Brenner wrote:
@torbrenner approved this pull request.
In ccp/modules/dnpm-node-compose.yml:
@@ -58,7 +58,7 @@ services:
dnpm-backend:
container_name: bridgehead-dnpm-backend
- image: ghcr.io/dnpm-dip/backend:${DNPM_IMAGE_TAG:-latest}
+ image: ghcr.io/dnpm-dip/api-gateway:latest
wouldn't it make sense to also use here an environment variable for the image tag?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>
[
{
***@***.***": "http://schema.org",
***@***.***": "EmailMessage",
"potentialAction": {
***@***.***": "ViewAction",
"target": "#338 (review)",
"url": "#338 (review)",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
***@***.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.