Add instructions for running example app#66
Merged
andriy-shevtsov-moc merged 1 commit intodevelopmentfrom Aug 5, 2025
Merged
Conversation
andriy-shevtsov-moc
requested review from
1toomas,
Andrii-Horishnii-Glia and
dmytrokellerglia
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
1toomas
reviewed
Aug 5, 2025
Contributor
1toomas
left a comment
1toomas
left a comment
There was a problem hiding this comment.
It looks like I had a lot of comments but essentially these are mostly about sub-bullets (you to decide how you'd like) and periods at the end of bullets.
1toomas
reviewed
Aug 5, 2025
Contributor
1toomas
left a comment
1toomas
left a comment
There was a problem hiding this comment.
Could you make these two more small changes?
Move useful information from CONTRIBUTING.md to the example-app/README.md
andriy-shevtsov-moc
force-pushed
the
feature/add-instructions-for-running-example-app
branch
from
a2ca12a to
296107e
Compare
Contributor
Author
|
@1toomas Thank you for your comments. |
andriy-shevtsov-moc
deleted the
feature/add-instructions-for-running-example-app
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://salemove.slack.com/archives/C01F9K88SQZ/p1752761707514569 for additional context.