Conversation
CI broke after the category merge because: 1. recommendation_bigquery.SEGMENT_TO_CATEGORY still mapped Ticketmaster's "Arts & Theatre" segment to the old "Arts & Culture" name. The runtime invariant in that module compares this mapping against ALLOWED_CATEGORIES and asserts at import time — which is why every test file errored at collection rather than just one test. 2. test_events_endpoint.py hardcoded "Arts & Culture" in two assertions. All 88 tests pass locally now. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI was failing on main because the category merge missed two spots: SEGMENT_TO_CATEGORY in recommendation_bigquery.py (which has a startup invariant against ALLOWED_CATEGORIES — assertion fired at import, breaking all 5 test files at collection) and two hardcoded assertions in test_events_endpoint.py. All 88 tests pass locally now.