ci: provision a loopback LIO iSCSI target and run test-tool/iscsi-test-cu against it - #471
Merged
Merged
Conversation
This makes it a little more intuitive for people who want to test locally from a non-master branch before submitting a PR. An alternative might be to instead only test on pull-request. Signed-off-by: David Disseldorp <ddiss@suse.de>
apt-get install runs a bunch of post-install checks which take quite some time to complete. It makes sense to only run then once after installing all desired packages. Signed-off-by: David Disseldorp <ddiss@suse.de>
The Github ubuntu-latest runner carries LIO kernel modules, so provision a file-backed iSCSI target listening on 127.0.0.1. This will be used as a test-tool target in a subsequent commit. Signed-off-by: David Disseldorp <ddiss@suse.de>
Contributor
Author
|
Running all |
Attempt to run Read10 and Write10 tests against the loopback target. Signed-off-by: David Disseldorp <ddiss@suse.de>
ddiss
force-pushed
the
lio-loopback-target
branch
from
June 3, 2026 03:47
b2caa56 to
fc67ea0
Compare
Contributor
Author
I've changed it to only run the Read10 and Write10 tests, which pass against the loopback LIO target in around 3 minutes. |
Owner
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ubuntu-latestgithub runner already carries the LIO kernel modules, so setup a basic loopback iSCSI target via configfs and then runtest-tool/iscsi-test-cuagainst it.I currently have it running all tests, but it might make sense to only run a few sanity checks, or the example binaries. It'll likely burn through CI credits pretty quickly if used as-is.Edit: it's now only running Read10 and Write10 tests against the loopback target, which pass in around 3 minutes.