Allow ffmpeg to copy the stream if the requested dimensions are similar enough#6
Open
KodeCR wants to merge 2 commits intosahilchaddha:masterfrom
Open
Allow ffmpeg to copy the stream if the requested dimensions are similar enough#6KodeCR wants to merge 2 commits intosahilchaddha:masterfrom
KodeCR wants to merge 2 commits intosahilchaddha:masterfrom
Conversation
…ar to it, and copy the stream instead of re-encoding if the request matches
Owner
|
@KodeCR PR looks good. |
Contributor
|
@sahilchaddha for uploading to npm, just use release-it. ( |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes allow homebridge-dafang to copy the stream instead of re-encoding it when the requested dimensions are similar to the stream coming from the camera. It detects the width and height from the stream automatically using ffprobe. I also refactored the ffmpeg option handling to support it more easily, now allowing global_options and input_options. Note that this doesn't take into account bitrate and fps. Also note the (image) source no longer is expected to contain the "-i ".