mbdvtxmap now being filled during calpass 2#4275
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThe PR refines the vertex creation and recording logic in ChangesMBD Vertex Recording
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 2151bfd7-34a9-4eb1-99af-6d5e40b34530
📒 Files selected for processing (1)
offline/packages/mbd/MbdReco.cc
Build & test reportReport for commit 97aeb59b00060d4c4eadc6c025f8c6aeaee79583:
Automatically generated by sPHENIX Jenkins continuous integration |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
comment: needed to do vertex match to tracking vertex
Types of changes
What kind of change does this PR introduce? (Bug fix, feature, ...)
TODOs (if applicable)
Links to other PRs in macros and calibration repositories (if applicable)
MBD Vertex Map Population Extended to Calibration Pass 2
Motivation / Context
The MBD (Minimum Bias Detector) vertex reconstruction is critical for global vertex matching with the tracking system. Previously, the
MbdVertexMapwas only populated during calibration pass 0 (_calpass==0), limiting vertex matching availability during other processing stages. This change extends vertex map population to calibration pass 2 and other passes (except pass 1), enabling broader support for vertex matching workflows while maintaining compatibility with fits-only mode.Key Changes
_calpass==0to_calpass!=1, expanding vertex map population to calibration passes 0, 2, 3, and potentially higher, while explicitly excluding pass 1!_fitsonlycheck from an inner conditional into the outer condition guard, removing nested logic and directly gating the entire vertex creation blockif (!_fitsonly)guard aroundm_mbdvtxmap->insert(vertex), now executed directly when the outer condition is satisfiedPotential Risk Areas
_calpass!=1), likely because it serves a different role in calibration; any modifications to pass numbering conventions could inadvertently affect this logic_fitsonly=trueacross all passes; verify that this aligns with intended behavior for all calibration configurationsPossible Future Improvements
Note: AI-assisted analysis is used throughout this summary. Please validate the reconstruction logic against your collaboration's calibration workflow documentation and test the impact on downstream vertex matching algorithms.