Organize thirds and size actions into menu submenus#1721
Closed
MyronKoch wants to merge 2 commits intorxhanson:mainfrom
Closed
Organize thirds and size actions into menu submenus#1721MyronKoch wants to merge 2 commits intorxhanson:mainfrom
MyronKoch wants to merge 2 commits intorxhanson:mainfrom
Conversation
Move thirds (First Third through Last Two Thirds) and size actions (Almost Maximize, Maximize Height, Larger, Smaller) into their own submenus in the menu bar dropdown, matching the existing pattern used by fourths, sixths, eighths, and move actions. Also removes the conditional hiding of the eighths submenu, making it always visible like all other grid categories. This reduces menu clutter for users with many grid sizes enabled, particularly on large displays and multi-monitor setups. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add largerWidth, smallerWidth, largerHeight, smallerHeight to the .size category so all size-related actions appear in the Size submenu - Remove dead eighthsMenuItem property from AppDelegate (no longer assigned after removing the conditional hiding logic) - Remove dead reference in SettingsViewController toggle handler Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
Rectangle has had these menu items this way for quite some time. I agree with the path presented here, but at first cut I would prefer that the existing menu be left as-is by default and provide additional settings for converting those sections into submenus. Let's keep the eighths setting in place, as this is configurable in the ellipsis button popover in the General tab. |
Author
|
Makes sense to keep the existing menu as the default. I'll add a preference toggle (e.g., "Use submenus for grid positions") in the ellipsis popover that converts the flat menu sections into submenus when enabled. The eighths checkbox stays as-is. I'll update the PR branch to reflect this approach. |
8 tasks
Author
|
Closing per Ryan's feedback - incorporating menu submenu changes into #1720. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
As Rectangle gains more window positions (fourths, sixths, eighths, ninths, and potentially twelfths/sixteenths), the status bar dropdown menu becomes unwieldy. Submenus keep the top-level menu scannable while making all actions discoverable. This is particularly helpful for users with large displays (50" 4K TVs, ultrawides, multi-monitor setups) who actively use the full range of grid positions.
Changes
WindowAction.swift- Adds.thirdsand.sizeto thecategoryproperty and marksfirstThirdandlargerasfirstInGroupfor their respective submenusAppDelegate.swift- Removes theif categoryMenu.category == .eighthsblock that was hiding eighths from the menuTest plan
🤖 Generated with Claude Code