fix(reviewer-bot): clarify /release command behavior and guidance#410
Open
PLeVasseur wants to merge 1 commit intorustfoundation:mainfrom
Open
fix(reviewer-bot): clarify /release command behavior and guidance#410PLeVasseur wants to merge 1 commit intorustfoundation:mainfrom
PLeVasseur wants to merge 1 commit intorustfoundation:mainfrom
Conversation
✅ Deploy Preview for scrc-coding-guidelines ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
|
@PLeVasseur should it be From the context of where the command is invoked, it would always know who the current reviewer is, right? |
Collaborator
|
@guidelines-bot /r? producers |
Contributor
|
@cpetig is designated as reviewer by queue rotation, but GitHub could not add them to PR Reviewers automatically (API 422). A triage+ approver may still be required before merge queue. |
Contributor
|
✅ @cpetig remains designated as reviewer in bot state. GitHub reviewer assignment could not be completed. |
github-actions
bot
added
the
status: awaiting reviewer response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/releaseusage explicit everywhere the bot documents commands by splitting self release and triage release forms/releasefailure messaging for non current reviewers with actionable guidance that points to/release @current-reviewer/commandsoutput, and the confusing non current reviewer release pathsTesting
uv run ruff check --fix scripts/reviewer_bot.py .github/reviewer-bot-tests/test_reviewer_bot.pyuv run python -m pytest .github/reviewer-bot-tests/test_reviewer_bot.py -k releaseuv run python -m pytest .github/reviewer-bot-tests/test_reviewer_bot.pyCloses #406