Merged
Conversation
Signed-off-by: Alex T. <frozen.and.blue@gmail.com>
Member
|
The test probably fails because you don't have the webassembly target installed on your system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I didn't get any reply in the discussion, and I see Clippy fixes in the git log, I decided to simply go ahead and submit this one.
Fixes this;
BTW, the
test_wasmtest fails onmaster. I haven't looked any deeper into why, but also don't see any open issues for that. Is the failure expected? Would it be helpful if I looked into that?