Skip to content

build(deps): update allocator-api2 to 0.4#18

Merged
mkroening merged 1 commit intomainfrom
update-allocator-api2
Feb 27, 2026
Merged

build(deps): update allocator-api2 to 0.4#18
mkroening merged 1 commit intomainfrom
update-allocator-api2

Conversation

@mkroening
Copy link
Member

No description provided.

@mkroening mkroening self-assigned this Jan 29, 2026
@phip1611
Copy link
Member

why don't you use dependabot for this?

@mkroening
Copy link
Member Author

why don't you use dependabot for this?

Because I want to avoid the noise from updating Cargo.lock a lot. Updating dependencies in Cargo.toml is often worth a thought to me.

For example, I think that this PR is breaking since users need to use the right allocator-api2 version, but cargo-semver-checks cannot check cross-crate items yet.

#17 on the other hand, should not be breaking, since no items from other crates are involved for users.

@phip1611
Copy link
Member

Because I want to avoid the noise from updating Cargo.lock a lot.

Are you worried about all the PRs you have to merge? It is fairly easy to configure dependabot to automerge everything. I use it in all my repos. 🤔 breaking changes weren't an issue for me so far (luckily)

@mkroening
Copy link
Member Author

Are you worried about all the PRs you have to merge? It is fairly easy to configure dependabot to automerge everything. I use it in all my repos. 🤔 breaking changes weren't an issue for me so far (luckily)

Not really; I think it just feels tidier for me personally if a library does not have a libc bump in the Cargo.lock every week, which makes the history less easy to scroll around in. Of course, one could reduce the frequency, but I think I generally prefer running cargo update before a release.

I have considered automating merges, but reading through the updates is interesting to me most of the time and reveals new possibilities to adapt to.

@phip1611
Copy link
Member

is there a reason to support the allocator-api? I know it is a downstream crate. But at least the upstream effort is dead. I also removed the allocator-api of all my crates for that reason

(I suppose allocator-api2 wants to stay close to the rustlang feature)

@mkroening
Copy link
Member Author

The upstream design has not changed a lot and will not be stabilized, yes, but there is nothing else to use, is there?

I think it makes sense for virtq::Used and virtq::Avail to be allocatable from something apart from the #[global_allocator], since these types are used for device communication. On nightly, we can use the never-to-be-stabilized allocator API. I can personally live with the nightly support, but it feels lacking not to give any possibility to allocate these types on a non-global allocator on stable, even though the allocation API has no future in its current form.

@phip1611
Copy link
Member

I see. A shame that they didn't build something like the allocator_api right from the beginning

@mkroening mkroening added this pull request to the merge queue Feb 27, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 27, 2026
@mkroening mkroening force-pushed the update-allocator-api2 branch from d547827 to f118b78 Compare February 27, 2026 08:34
@mkroening mkroening added this pull request to the merge queue Feb 27, 2026
Merged via the queue into main with commit c84ba20 Feb 27, 2026
14 checks passed
@mkroening mkroening deleted the update-allocator-api2 branch February 27, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants