Skip to content

Add the concept of community reviews before PR assignment#2426

Merged
Urgau merged 1 commit into
rust-lang:masterfrom
Urgau:assign-community-reviews
Jun 17, 2026
Merged

Add the concept of community reviews before PR assignment#2426
Urgau merged 1 commit into
rust-lang:masterfrom
Urgau:assign-community-reviews

Conversation

@Urgau

@Urgau Urgau commented Jun 3, 2026

Copy link
Copy Markdown
Member

This PR adds the concept of community reviews before PR assignment.

It's enabled in the [assign] handler with a new config:

[assign.community_reviews]
minimum_approvals = 2
label = "S-waiting-on-community-reviews"

The normal workflow for community reviews is like this:

  1. PR is being opened (non-draft, otherwise ignore until ready)
    • Add the label
    • Post the welcome message if new user, with small explanation of community reviews
      • No message for recurring users
  2. Min approval reviews is reached (or label is manually removed)
    • Normal PR assignment
    • Assignment message

If someone is being assigned with our commands (r?, reroll), we remove the label after the assignment, thus preventing further auto-assign.

I tested what I could on my private repo, the core logic seems to work, although I couldn't test everything since I'm alone.

cc @samueltardieu

@Urgau
Urgau requested a review from Kobzol June 3, 2026 21:38
@Urgau
Urgau force-pushed the assign-community-reviews branch from 61eb452 to 583bfeb Compare June 4, 2026 16:12
Comment thread src/handlers/assign/messages.rs Outdated
Comment on lines +16 to +17
"Thanks for the pull request, and welcome!\
You should hear from the project after a minimum of {min_reviews} community reviews have been reached."

@blyxyas blyxyas Jun 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make this message configurable? We'd love to link this blog post, at least temporarily, and possibly make a reviewing guide.

View changes since the review

@Urgau Urgau Jun 14, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a configurable link in the [assign] handler: contributing_url. You could change it to your blog post or link it to inside your contributing file. (The associated text is defined here)

But in general I would like to avoid making more messages configurable, it's a pain to deal with, but if the option above doesn't work let me know.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, feel free to suggest any text changes. I didn't think too much about them.

@Kobzol Kobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks great, and relatively simple.

View changes since this review

Comment thread src/handlers/assign/messages.rs Outdated
Comment thread src/handlers/assign/messages.rs Outdated
Comment thread src/handlers/assign.rs
Comment thread src/handlers/assign.rs Outdated
Comment thread src/handlers/assign.rs Outdated
Comment thread src/handlers/assign.rs Outdated
Comment thread src/handlers/assign.rs
Comment thread src/config.rs Outdated
Comment thread src/config.rs Outdated
@Urgau
Urgau force-pushed the assign-community-reviews branch from 583bfeb to 130460d Compare June 15, 2026 19:14

@Kobzol Kobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one additional comment, but that's not super important I think. Feel free to merge, great work!

View changes since this review

Comment thread src/handlers/assign.rs
@Urgau
Urgau added this pull request to the merge queue Jun 17, 2026
Merged via the queue into rust-lang:master with commit a67cb58 Jun 17, 2026
3 checks passed
@Urgau
Urgau deleted the assign-community-reviews branch June 17, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants