Skip to content

Tweak how the "copy path" rustdoc button works to allow some accessibility tool to work with rustdoc#155395

Open
GuillaumeGomez wants to merge 1 commit intorust-lang:mainfrom
GuillaumeGomez:copy-path-with-ronga
Open

Tweak how the "copy path" rustdoc button works to allow some accessibility tool to work with rustdoc#155395
GuillaumeGomez wants to merge 1 commit intorust-lang:mainfrom
GuillaumeGomez:copy-path-with-ronga

Conversation

@GuillaumeGomez
Copy link
Copy Markdown
Member

Fixes #155032.

It's a bit better in term of "fragility" to retrieve this information: no need to parse text anymore, just to retrieve content. However it relies on HTML. I added extra tests to ensure it won't break without notice.

cc @Enyium

r? @lolbinarycat

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 16, 2026

Some changes occurred in HTML/CSS/JS.

cc @lolbinarycat

@rustbot rustbot added the A-rustdoc-js Area: Rustdoc's JS front-end label Apr 16, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Apr 16, 2026
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez
Copy link
Copy Markdown
Member Author

Fixed typescript issues. The fix for some of them was so awful that I just preferred using // @ts-expect-error (casting an Element into an HTMLElement to satisfy tsc is really strange, and definitely something I don't want to do).

@GuillaumeGomez
Copy link
Copy Markdown
Member Author

@bors r=notriddle rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 16, 2026

📌 Commit 6c4ec59 has been approved by notriddle

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Apr 16, 2026
…a, r=notriddle

Tweak how the "copy path" rustdoc button works to allow some accessibility tool to work with rustdoc

Fixes rust-lang#155032.

It's a bit better in term of "fragility" to retrieve this information: no need to parse text anymore, just to retrieve content. However it relies on HTML. I added extra tests to ensure it won't break without notice.

cc @Enyium

r? @lolbinarycat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rustdoc-js Area: Rustdoc's JS front-end S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copy-identifier button copies extra text when accessibility software prefixes title

5 participants