Small refactor of QueryJob::latch method#155391
Open
zetanumbers wants to merge 1 commit intorust-lang:mainfrom
Open
Small refactor of QueryJob::latch method#155391zetanumbers wants to merge 1 commit intorust-lang:mainfrom
QueryJob::latch method#155391zetanumbers wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
r? @chenyukang rustbot has assigned @chenyukang. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
|
r? @petrochenkov |
Contributor
rust-bors
bot
added
the
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 16, 2026
…r=petrochenkov Small refactor of `QueryJob::latch` method We can use `Option::get_or_insert_with` to avoid unwrapping there.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 16, 2026
…r=petrochenkov Small refactor of `QueryJob::latch` method We can use `Option::get_or_insert_with` to avoid unwrapping there.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Apr 16, 2026
…r=petrochenkov Small refactor of `QueryJob::latch` method We can use `Option::get_or_insert_with` to avoid unwrapping there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can use
Option::get_or_insert_withto avoid unwrapping there.